fix: do not mark computed React[...] methods as pure#14528
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 17, 2022
Merged
fix: do not mark computed React[...] methods as pure#14528nicolo-ribaudo merged 1 commit intobabel:mainfrom
React[...] methods as pure#14528nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
4ea92cf to
cc15e42
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51851/ |
nicolo-ribaudo
approved these changes
May 5, 2022
| // code elimination. | ||
| // See https://reactjs.org/docs/react-api.html | ||
| const PURE_CALLS = new Map([ | ||
| const PURE_CALLS: [string, Set<string>][] = [ |
Member
There was a problem hiding this comment.
This is not a map anymore because we never relied on O(1) access, right?
Contributor
Author
There was a problem hiding this comment.
Yes, we always loop through the structure, better just use array for that purpose.
| } | ||
| const object = calleePath.get("object"); | ||
| const callee = calleePath.node; | ||
| if (!callee.computed && t.isIdentifier(callee.property)) { |
Member
There was a problem hiding this comment.
Note: this computed check is the only real fix, everything else is a minor refactor.
existentialism
approved these changes
May 17, 2022
React[...] methods as pure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-pure-annotationsmarksReact[createElement]as pure.Also improved typings.