Transform await in computed class keys#14391
Conversation
...osal-async-generator-functions/test/fixtures/async-generators/transform-class-keys/output.js
Outdated
Show resolved
Hide resolved
...nc-generator-functions/test/fixtures/async-generators/transform-class-keys/babel.config.json
Outdated
Show resolved
Hide resolved
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52376/ |
|
I have modified |
|
It seems that you need to run the yarn command in the root directory and then commit the .lock file. |
|
@liuxingbaoyu wow I have noticed your comment after 20 days since you commented (unfortunately)! |
|
Can you do a rebase? |
|
We lint Babel using Babel itself, so you need to compile ( |
|
@Yokubjon-J It looks like something went wrong when rebasing, do you need any help? |
|
@nicolo-ribaudo Thank you, I would be very happy! |
|
What I wanted to do with rebase is update my branch |
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
1c1202e to
03fd7d2
Compare
|
Great, CI all passed. |
|
Oh I thank you very much @nicolo-ribaudo! It was so fast! I thought it would be a complicated process. Now I am going to work on the issue of the bug. |
|
@Yokubjon-J If you also need help with downloading the updated branch, you probably have to do something like this: |
|
Even though environmentVisitor is merged in |
yield/await in computed class keysawait in computed class keys
|
@Yokubjon-J The reason why it's not working is because we are still doing |
|
Actually, we probably still need to manually skip |
|
I think I am getting errors because I forgot to run |
packages/babel-plugin-proposal-async-generator-functions/src/index.ts
Outdated
Show resolved
Hide resolved
…ndex.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
|
Can you run |
|
@nicolo-ribaudo Thank you a lot! I have learned so much! Especially getting to know that class methods (inside classes) are treated as function methods was insightful! |
|
Hey, no need to keep this up to date with |
|
Generally, rebasing is only required after there have been a lot of changes in the main branch. |
|
@liuxingbaoyu I am afraid of rebasing for the fear of getting that problem again :) |
|
This is normal, I screwed everything up the first time I did the rebase. |

Uh oh!
There was an error while loading. Please reload this page.