feat: support startColumn option#13887
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Oct 28, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49454/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac9c7de:
|
nicolo-ribaudo
approved these changes
Oct 27, 2021
existentialism
approved these changes
Oct 27, 2021
startColumn option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
startColumnoption in Babel parser. LikestartLine, thestartColumnindicates the starting column position of the input string in the source code. For example, consider a wrapperwhere
[code]is a string from which Babel parser will generate AST. A user will expect the generated location info correctly maps to the location in the wrapped code, in this case, he/she should pass{ "startColumn": 60 }to Babel parser so that the line 1 column 0 at
[code]maps to line 1 column 60 in the wrapped source. Not that unlikestartLine, thestartColumnis 0-based, its default value is 0.