Force loading plugins/presets from the monorepo in tests#13858
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Oct 18, 2021
Merged
Force loading plugins/presets from the monorepo in tests#13858nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d0a1be:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49251/ |
Merged
ece9f58 to
8d0a1be
Compare
JLHwung
approved these changes
Oct 17, 2021
fedeci
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
@babel/-prefixed plugins/presets, they are always loaded fromnode_modules. With Yarn 2 and Yarn 3 we were lucky enough that the version resolved innode_moduleswas a symlink to the monorepo version, but due to some changes to the hoisting algorithm this isn't true anymore in Yarn 3.1 (so it uncovered the bug).