Await promises from sync iterators with for-await#13824
Merged
nicolo-ribaudo merged 4 commits intobabel:mainfrom Oct 7, 2021
Merged
Await promises from sync iterators with for-await#13824nicolo-ribaudo merged 4 commits intobabel:mainfrom
for-await#13824nicolo-ribaudo merged 4 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Oct 6, 2021
| return method.call(iterable); | ||
| } | ||
|
|
||
| function AsyncFromSyncIterator(s) { |
Member
Author
There was a problem hiding this comment.
The spec for this is at https://tc39.es/ecma262/#sec-async-from-sync-iterator-objects
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49101/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34b58f0:
|
lightmare
reviewed
Oct 7, 2021
JLHwung
reviewed
Oct 7, 2021
| }); | ||
|
|
||
| helpers.asyncIterator = helper("7.0.0-beta.0")` | ||
| helpers.asyncIterator = helper("7.15.9")` |
Contributor
There was a problem hiding this comment.
Q: why should we bump helper minimum version here?
Member
Author
There was a problem hiding this comment.
Uh probably it's not needed. It's always a choice between "updating the plugin and @babel/core is enough to get the bugfix" vs "you also need to update @babel/runtime".
JLHwung
approved these changes
Oct 7, 2021
existentialism
approved these changes
Oct 7, 2021
Co-authored-by: Mickey Rose <lightmare@users.noreply.github.com>
This was referenced Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can be easily reviewed commit-by-commit.