getBindingIdentifiers should return params for private methods#13723
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48478/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5bfc350:
|
hzoo
approved these changes
Sep 2, 2021
hzoo
reviewed
Sep 2, 2021
| import Binding from "./binding"; | ||
| import globals from "globals"; | ||
| import { | ||
| FOR_INIT_KEYS, |
Contributor
Author
There was a problem hiding this comment.
The FOR_INIT_KEYS is only used here. After this PR we may even remove it in Babel 8 if nobody else is using.
5ab190d to
5bfc350
Compare
getBindingIdentifiers should return params for private methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t.getBindingIdentifiersdoes not return parameter bindings for private class methodsAlso include minor tweaks around scope tracking.
Performant issue
The
getBindingIdentifiersis generally slow due to heavy dynamics: it even allows monkey-patching its visitor keys:getBindingIdentifiers.keyscan be modified by external plugins. In my local perf test, droppinggetBindingIdentifiers.keyscan achieves 10x performance boost:Details
currentis new implementation inlining visitor keys,current2is a new implementation based oncurrentwhich returns bindings in tail-first order: so we can avoid unnecessary memcpy introduced byarray.shiftinbabel/packages/babel-types/src/retrievers/getBindingIdentifiers.ts
Line 43 in 804a94f
we should reconsider whether we are going to support
getBindingIdentifiers.keysin Babel 8.