Skip to content

Disallow reinitializing private elements#13601

Merged
nicolo-ribaudo merged 33 commits into
babel:mainfrom
komyg:fix/bug-13299-class-members
Aug 30, 2021
Merged

Disallow reinitializing private elements#13601
nicolo-ribaudo merged 33 commits into
babel:mainfrom
komyg:fix/bug-13299-class-members

Conversation

@komyg

@komyg komyg commented Jul 26, 2021 •
edited by nicolo-ribaudo
Loading

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #13299
Patch: Bug Fix
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes? No
License MIT

@komyg komyg changed the title Fix/bug 13299 class members Fix 13299 Jul 26, 2021
@komyg komyg mentioned this pull request Jul 26, 2021
Closed
1 task
@jridgewell jridgewell changed the title Fix 13299 Fix reinitialized private field Jul 26, 2021
@babel-bot

babel-bot commented Jul 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48244/

@codesandbox-ci

codesandbox-ci Bot commented Jul 26, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebf193c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields labels Jul 26, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Jul 30, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 2, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
Comment thread packages/babel-helpers/src/helpers.js Outdated
Comment thread packages/babel-helpers/src/helpers.js Outdated
@colinaaa

colinaaa commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

Since #13570 has been merged, you probably need to rebase to main and write code with typings

@komyg

komyg commented Aug 5, 2021

Copy link
Copy Markdown
Contributor Author

Since #13570 has been merged, you probably need to rebase to main and write code with typings

Done!

Thank you for the typings by the way. They will be very hepful.

nicolo-ribaudo
nicolo-ribaudo reviewed Aug 5, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 5, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
@nicolo-ribaudo

nicolo-ribaudo commented Aug 7, 2021

Copy link
Copy Markdown
Member

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

@komyg

komyg commented Aug 7, 2021

Copy link
Copy Markdown
Contributor Author

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

Done.

I've pushed all the snapshot changes.

nicolo-ribaudo
nicolo-ribaudo reviewed Aug 11, 2021
View reviewed changes
Comment thread packages/babel-helpers/src/helpers.js Outdated
@nicolo-ribaudo

nicolo-ribaudo commented Aug 11, 2021

Copy link
Copy Markdown
Member

The CI failure would be fixed by rebasing; don't worry about it.

@komyg komyg marked this pull request as ready for review August 12, 2021 16:42
@komyg komyg requested a review from nicolo-ribaudo August 16, 2021 11:30
nicolo-ribaudo
nicolo-ribaudo approved these changes Aug 16, 2021
View reviewed changes

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
jridgewell
jridgewell approved these changes Aug 17, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
komyg and others added 4 commits August 18, 2021 07:12
@komyg @jridgewell
Update packages/babel-helper-create-class-features-plugin/src/fields.ts
d187a77 
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@komyg @jridgewell
Update packages/babel-helper-create-class-features-plugin/src/fields.ts
1d33cf2 
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@komyg @jridgewell
Update packages/babel-helper-create-class-features-plugin/src/fields.ts
f9eb76a 
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@komyg
Clone id nodes
ebf193c
@komyg

komyg commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @nicolo-ribaudo, @jridgewell, @JLHwung and @colinaaa, I've incorporated all of your suggestions and added the latest changes from the main branch.

Would you like to re-review it?

jridgewell
jridgewell approved these changes Aug 18, 2021
View reviewed changes

@jridgewell jridgewell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

nicolo-ribaudo
nicolo-ribaudo approved these changes Aug 30, 2021
View reviewed changes

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo nicolo-ribaudo changed the title Fix reinitialized private field Disallow reinitializing private elements Aug 30, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit fdfe978 into babel:main Aug 30, 2021
@komyg komyg deleted the fix/bug-13299-class-members branch August 30, 2021 11:16
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@JLHwung JLHwung Awaiting requested review from JLHwung

+1 more reviewer

@colinaaa colinaaa colinaaa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Class Private Fields/Accessors/Methods must not be re-initialized on instance

6 participants

@komyg @babel-bot @colinaaa @nicolo-ribaudo @jridgewell @JLHwung