fix: remove traverse trap on NODE_ENV == "test"#13475
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46939/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de43660:
|
nicolo-ribaudo
approved these changes
Jun 16, 2021
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
This is meant to help us when developing plugin, but I have never seen this error since I started contributing.
As an alternative, we can keep it but strip it away at publish time.
hzoo
approved these changes
Jun 16, 2021
hzoo
left a comment
Member
There was a problem hiding this comment.
agreed, if it's meant for ourselves we should limit it to babel dev
existentialism
approved these changes
Jun 17, 2021
NODE_ENV == "test"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
NODE_ENVistest, Babel assumes infinite cycle is hit when Babel has a queue length > 10000. However, transforming a big file could result to large queue as in #13471 and #12218. Overall the behaviour is inconsistent in differentNODE_ENVsettings. We should align the behaviour and do not assume 10000 is too much for traverser.