Skip to content

fix: reference to class expression in private method#13429

Merged
nicolo-ribaudo merged 6 commits into
babel:mainfrom
lala7573:fix-13399
Jun 14, 2021
Merged

fix: reference to class expression in private method#13429
nicolo-ribaudo merged 6 commits into
babel:mainfrom
lala7573:fix-13399

Conversation

@lala7573

@lala7573 lala7573 commented Jun 6, 2021 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #13399
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot

babel-bot commented Jun 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46851/

@lala7573 lala7573 mentioned this pull request Jun 6, 2021
Closed
1 task
@codesandbox-ci

codesandbox-ci Bot commented Jun 6, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fad6be1:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

lala7573
lala7573 commented Jun 6, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/index.ts Outdated
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods labels Jun 8, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Jun 8, 2021
View reviewed changes

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread packages/babel-helper-create-class-features-plugin/src/index.ts Outdated
Comment thread packages/babel-helper-create-class-features-plugin/src/index.ts Outdated
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
JLHwung
JLHwung reviewed Jun 8, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
@nicolo-ribaudo

nicolo-ribaudo commented Jun 8, 2021

Copy link
Copy Markdown
Member

The CI / E2E (babel-old-version) failure has been fixed on main so you can safely ignore it.

@lala7573
modify path.node.name instead of requeueing the AST node
9f9f5f9 
remove wrapper function on test which is no need
split innerBinding from ref because ref is AST node.
nicolo-ribaudo
nicolo-ribaudo approved these changes Jun 9, 2021
View reviewed changes

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hzoo
hzoo reviewed Jun 10, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated
hzoo
hzoo reviewed Jun 10, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/index.ts Outdated
hzoo
hzoo approved these changes Jun 10, 2021
View reviewed changes

@hzoo hzoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests lgtm!

@lala7573 @hzoo
Apply suggestions from code review
48313eb 
apply feedbacks

Co-authored-by: Henry Zhu <hi@henryzoo.com>
fedeci
fedeci approved these changes Jun 12, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/index.ts Outdated
lala7573 and others added 2 commits June 14, 2021 18:21
@nicolo-ribaudo nicolo-ribaudo merged commit 903b600 into babel:main Jun 14, 2021
@lala7573 lala7573 deleted the fix-13399 branch June 15, 2021 10:13
@sync-by-unito sync-by-unito Bot mentioned this pull request Jun 15, 2021
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jun 17, 2021
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Jun 22, 2021
Closed
@colinaaa colinaaa mentioned this pull request Aug 8, 2021
Merged
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung left review comments

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@fedeci fedeci fedeci approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Reference to class expression in private methods is not correctly compiled

6 participants

@lala7573 @babel-bot @nicolo-ribaudo @hzoo @JLHwung @fedeci