[ts] Add asserts: false to TSTypePredicate node#12167
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Oct 13, 2020
Merged
[ts] Add asserts: false to TSTypePredicate node#12167nicolo-ribaudo merged 1 commit intobabel:mainfrom
asserts: false to TSTypePredicate node#12167nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29855/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f78410:
|
JLHwung
approved these changes
Oct 13, 2020
existentialism
approved these changes
Oct 13, 2020
Member
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When babel-parser parses asserts function, it attach
asserts: truetoTSTypePredicate.However, when parsing the normal type predication function, it doesn't attach
asserts: falsetoTSTypePredicate.typescript-eslint/typescript-estree adds
asserts: true/falseto both. This PR aligns AST for Babel and typescript-estree. (ref: https://github.com/typescript-eslint/typescript-eslint/blob/c41dbe56e0514846e4d21fc5fcd8847da50e92c6/packages/typescript-estree/tests/ast-alignment/utils.ts#L259-L268)Please close this PR if the current behavior is intentional:smile: