[ts] Add support for template interpolations in types#12131
[ts] Add support for template interpolations in types#12131nicolo-ribaudo merged 5 commits intobabel:mainfrom
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29203/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0648b48:
|
| while (!curElt.tail) { | ||
| this.expect(tt.dollarBraceL); | ||
| node.expressions.push(this.parseExpression()); | ||
| node.expressions.push(this.parseTemplateInterpolation()); |
There was a problem hiding this comment.
Can we extend parseTemplate in typescript plugin? since it seems to me that TemplateInterpolation is a TS-only concept.
There was a problem hiding this comment.
Isn't it the same concept as for js? i.e. a${x}b
Maybe if I call it parseTemplateSubstitution, which is the language used in the spec?
| giant.ts | ||
| globalThisDeclarationEmit.ts | ||
| globalThisDeclarationEmit2.ts | ||
| hugeDeclarationOutputGetsTruncatedWithError.ts |
There was a problem hiding this comment.
This is a type analysis error, it can't be caught at parse time.
https://devblogs.microsoft.com/typescript/announcing-typescript-4-1-beta/#template-literal-types