Skip to content

Typescript transform now removes generic arguments from optional calls (Fixes #11813)#11816

Merged
existentialism merged 2 commits intobabel:mainfrom
RafaelSalguero:main
Jul 9, 2020
Merged

Typescript transform now removes generic arguments from optional calls (Fixes #11813)#11816
existentialism merged 2 commits intobabel:mainfrom
RafaelSalguero:main

Conversation

@RafaelSalguero
Copy link
Copy Markdown
Contributor

@RafaelSalguero RafaelSalguero commented Jul 9, 2020

Q                       A
Fixed Issues? Fixes #11813
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Typescript transform now removes generic arguments from optional call expressions

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25744/

@JLHwung JLHwung added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 9, 2020
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jul 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30073ce:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism merged commit f32d5de into babel:main Jul 9, 2020
@existentialism
Copy link
Copy Markdown
Member

@RafaelSalguero thanks!

@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 9, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[typescript] Generic parameter is not removed when using the optional chaining operator

5 participants