fix: throw expect jsx plugin error when an idStart or > is seen#11774
Merged
JLHwung merged 3 commits intobabel:mainfrom Jul 1, 2020
Merged
fix: throw expect jsx plugin error when an idStart or > is seen#11774JLHwung merged 3 commits intobabel:mainfrom
JLHwung merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25008/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c666018:
|
existentialism
approved these changes
Jul 1, 2020
Contributor
|
What |
kaicataldo
approved these changes
Jul 1, 2020
Member
Yeah, it'll fall through: https://github.com/babel/babel/pull/11774/files#diff-56fea09eea2de51b8291db400d2f69beR1193 |
Contributor
Author
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #11722 , we throw expecting JSX errors when an IdentifierStart or
>is seen after<. This should cover type parameters, JSX element name and JSX fragment shorthand.This PR also moves
html-commenttest tobasic, since it is not an error test.