Skip to content

Fix innercomments#11697

Merged
existentialism merged 5 commits intobabel:masterfrom
shaodahong:fix-innercomments
Jun 13, 2020
Merged

Fix innercomments#11697
existentialism merged 5 commits intobabel:masterfrom
shaodahong:fix-innercomments

Conversation

@shaodahong
Copy link
Copy Markdown
Contributor

@shaodahong shaodahong commented Jun 9, 2020 •
edited
Loading

Q                       A
Fixed Issues? Fixes #11469
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jun 9, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23787/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 9, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 579394c:

Sandbox Source
dreamy-wu-135fz Configuration
new-bash-2wgc0 Configuration

@shaodahong shaodahong force-pushed the fix-innercomments branch from 2dc44cb to 104cb81 Compare June 9, 2020 15:22
kaicataldo
kaicataldo requested changes Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Can you fix up the failing tests in CI?

@kaicataldo kaicataldo added area: comments pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jun 9, 2020
existentialism
existentialism reviewed Jun 10, 2020
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism merged commit e15a5c7 into babel:master Jun 13, 2020
@existentialism
Copy link
Copy Markdown
Member

existentialism commented Jun 13, 2020

@shaodahong thanks!

@shaodahong shaodahong deleted the fix-innercomments branch June 13, 2020 02:26
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism left review comments

@JLHwung JLHwung JLHwung left review comments

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees

No one assigned

Labels

area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trailing comments of ClassMethod are reported as trailing comments of BlockStatement when the method has no code inside but has a comment

6 participants

@shaodahong @babel-bot @existentialism @JLHwung @nicolo-ribaudo @kaicataldo