Move window defined check before window.XMLHttpRequest check#1160
Merged
nickuraltsev merged 1 commit intoaxios:masterfrom Nov 11, 2017
Merged
Move window defined check before window.XMLHttpRequest check#1160nickuraltsev merged 1 commit intoaxios:masterfrom
nickuraltsev merged 1 commit intoaxios:masterfrom
Conversation
window defined check before window.XMLHttpRequest check
Contributor
|
Thank you! |
jimthedev
referenced
this pull request
in commitizen/cz-cli
May 24, 2018
This Pull Request updates dependency [axios](https://github.com/axios/axios) from `v0.15.2` to `v0.18.0` <details> <summary>Release Notes</summary> ### [`v0.18.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0180-Feb-19-2018) [Compare Source](axios/axios@v0.17.1...v0.18.0) - Adding support for UNIX Sockets when running with Node.js ([#​1070](`https://github.com/axios/axios/pull/1070`)) - Fixing typings ([#​1177](`https://github.com/axios/axios/pull/1177`)): - AxiosRequestConfig.proxy: allows type false - AxiosProxyConfig: added auth field - Adding function signature in AxiosInstance interface so AxiosInstance can be invoked ([#​1192](`https://github.com/axios/axios/pull/1192`), [#​1254](`https://github.com/axios/axios/pull/1254`)) - Allowing maxContentLength to pass through to redirected calls as maxBodyLength in follow-redirects config ([#​1287](`https://github.com/axios/axios/pull/1287`)) - Fixing configuration when using an instance - method can now be set ([#​1342](`https://github.com/axios/axios/pull/1342`)) --- ### [`v0.17.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0171-Nov-11-2017) [Compare Source](axios/axios@v0.17.0...v0.17.1) - Fixing issue with web workers ([#​1160](`https://github.com/axios/axios/pull/1160`)) - Allowing overriding transport ([#​1080](`https://github.com/axios/axios/pull/1080`)) - Updating TypeScript typings ([#​1165](`https://github.com/axios/axios/pull/1165`), [#​1125](`https://github.com/axios/axios/pull/1125`), [#​1131](`https://github.com/axios/axios/pull/1131`)) --- ### [`v0.17.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0170-Oct-21-2017) [Compare Source](axios/axios@v0.16.2...v0.17.0) - **BREAKING** Fixing issue with `baseURL` and interceptors ([#​950](`https://github.com/axios/axios/pull/950`)) - **BREAKING** Improving handing of duplicate headers ([#​874](`https://github.com/axios/axios/pull/874`)) - Adding support for disabling proxies ([#​691](`https://github.com/axios/axios/pull/691`)) - Updating TypeScript typings with generic type parameters ([#​1061](`https://github.com/axios/axios/pull/1061`)) --- ### [`v0.16.2`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0162-Jun-3-2017) [Compare Source](axios/axios@v0.16.1...v0.16.2) - Fixing issue with including `buffer` in bundle ([#​887](`https://github.com/axios/axios/pull/887`)) - Including underlying request in errors ([#​830](`https://github.com/axios/axios/pull/830`)) - Convert `method` to lowercase ([#​930](`https://github.com/axios/axios/pull/930`)) --- ### [`v0.16.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0161-Apr-8-2017) [Compare Source](axios/axios@v0.16.0...v0.16.1) - Improving HTTP adapter to return last request in case of redirects ([#​828](`https://github.com/axios/axios/pull/828`)) - Updating `follow-redirects` dependency ([#​829](`https://github.com/axios/axios/pull/829`)) - Adding support for passing `Buffer` in node ([#​773](`https://github.com/axios/axios/pull/773`)) --- ### [`v0.16.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0160-Mar-31-2017) [Compare Source](axios/axios@v0.15.3...v0.16.0) - **BREAKING** Removing `Promise` from axios typings in favor of built-in type declarations ([#​480](`https://github.com/axios/axios/issues/480`)) - Adding `options` shortcut method ([#​461](`https://github.com/axios/axios/pull/461`)) - Fixing issue with using `responseType: 'json'` in browsers incompatible with XHR Level 2 ([#​654](`https://github.com/axios/axios/pull/654`)) - Improving React Native detection ([#​731](`https://github.com/axios/axios/pull/731`)) - Fixing `combineURLs` to support empty `relativeURL` ([#​581](`https://github.com/axios/axios/pull/581`)) - Removing `PROTECTION_PREFIX` support ([#​561](`https://github.com/axios/axios/pull/561`)) --- ### [`v0.15.3`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0153-Nov-27-2016) [Compare Source](axios/axios@v0.15.2...v0.15.3) - Fixing issue with custom instances and global defaults ([#​443](`https://github.com/axios/axios/issues/443`)) - Renaming `axios.d.ts` to `index.d.ts` ([#​519](`https://github.com/axios/axios/issues/519`)) - Adding `get`, `head`, and `delete` to `defaults.headers` ([#​509](`https://github.com/axios/axios/issues/509`)) - Fixing issue with `btoa` and IE ([#​507](`https://github.com/axios/axios/issues/507`)) - Adding support for proxy authentication ([#​483](`https://github.com/axios/axios/pull/483`)) - Improving HTTP adapter to use `http` protocol by default ([#​493](`https://github.com/axios/axios/pull/493`)) - Fixing proxy issues ([#​491](`https://github.com/axios/axios/pull/491`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Sep 22, 2019
This was referenced Oct 19, 2019
This was referenced Feb 9, 2020
This was referenced Feb 22, 2020
This was referenced Mar 2, 2020
This was referenced Mar 23, 2020
This was referenced Apr 1, 2020
This was referenced Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error being thrown due to the fact that we were checking for the
XMLHttpRequestproperty on thewindowobject before asserting thatwindowwas defined.Buy moving the window defined check ahead of the
window.XMLHttpRequestcheck, the error is eliminated!