Conversation
Instead of hard-coding Windows and *nix environment variables, rely on os.UserHomeDir() to do the right thing. Ignore errors since those only happen in situations we don't care about (and didn't handle previously). Signed-off-by: Stephen Kitt <skitt@redhat.com>
Contributor
Author
Ah yes, I missed the no-longer-necessary import! Thanks for the fixes. |
skmcgrail
approved these changes
Jan 22, 2022
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
Instead of hard-coding Windows and *nix environment variables, rely on os.UserHomeDir() to do the right thing. Ignore errors since those only happen in situations we don't care about (and didn't handle previously). Signed-off-by: Stephen Kitt <skitt@redhat.com> Co-authored-by: Jason Del Ponte <961963+jasdel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding Windows and *nix environment variables, rely on
os.UserHomeDir() to do the right thing. Ignore errors since those only
happen in situations we don't care about (and didn't handle
previously).
Signed-off-by: Stephen Kitt skitt@redhat.com
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.