Skip to content

Add ExtendedRequestId to APIGatewayProxyRequestContext#451

Merged
bmoffatt merged 1 commit intoaws:mainfrom
DanielBauman88:extended-request-id
Jul 12, 2022
Merged

Add ExtendedRequestId to APIGatewayProxyRequestContext#451
bmoffatt merged 1 commit intoaws:mainfrom
DanielBauman88:extended-request-id

Conversation

@DanielBauman88
Copy link
Contributor

@DanielBauman88 DanielBauman88 commented Jul 11, 2022

It exists on APIGatewayWebsocketProxyRequestContext but not ExtendedRequestId.
It is however present on non-websocket requests and should be accessible by consumers of this package.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DanielBauman88
Copy link
Contributor Author

DanielBauman88 commented Jul 11, 2022 •
edited
Loading

I validated this with my rest api by deploying my go code and replacing this module with my changes. The extended request id is accessible as expected.

This was supported for websocket requests when this was added but this was never supported for non-websocket requests.

This functionality is important so that customers can long the extendedRequestId in lambda code - this will match what's logged in the APIGW execution logs.

@DanielBauman88 DanielBauman88 marked this pull request as ready for review July 11, 2022 19:18
@DanielBauman88 DanielBauman88 mentioned this pull request Jul 11, 2022
Closed
@DanielBauman88
Add ExtendedRequestId to APIGatewayProxyRequestContext
fa013cf 
It exists on APIGatewayWebsocketProxyRequestContext but not ExtendedRequestId.
It is however present on non-websocket requests and should be accessible by consumers of this package.

* REST https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html
* HTTP https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-logging-variables.html
@DanielBauman88
Copy link
Contributor Author

DanielBauman88 commented Jul 11, 2022

Thanks for enabling the WFs. I noticed they failed on the first revision, pushed a new one and validated that the tests pass locally with

✗ go test -race -coverprofile=coverage.txt -covermode=atomic ./...

ok  	github.com/aws/aws-lambda-go/cfn	0.168s	coverage: 72.2% of statements
ok  	github.com/aws/aws-lambda-go/cmd/build-lambda-zip	17.898s	coverage: 54.7% of statements
ok  	github.com/aws/aws-lambda-go/events	0.450s	coverage: 83.2% of statements
?   	github.com/aws/aws-lambda-go/events/test	[no test files]
ok  	github.com/aws/aws-lambda-go/lambda	1.090s	coverage: 90.0% of statements
?   	github.com/aws/aws-lambda-go/lambda/handlertrace	[no test files]
?   	github.com/aws/aws-lambda-go/lambda/messages	[no test files]
?   	github.com/aws/aws-lambda-go/lambdacontext	[no test files]

bmoffatt
bmoffatt approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-input-format validated against docs sample

@bmoffatt
Copy link
Collaborator

bmoffatt commented Jul 12, 2022

Thanks!

@bmoffatt bmoffatt merged commit 6796528 into aws:main Jul 12, 2022
@DanielBauman88
Copy link
Contributor Author

DanielBauman88 commented Jul 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmoffatt bmoffatt bmoffatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielBauman88 @bmoffatt