Merged
Conversation
e55927f to
dd9acda
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7205 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 205 205
Lines 16424 16438 +14
==========================================
Hits 14 14
- Misses 16410 16424 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kyleknap
reviewed
Aug 23, 2022
Contributor
kyleknap
left a comment
There was a problem hiding this comment.
Looks good! I just had a couple of suggestions.
kyleknap
reviewed
Aug 25, 2022
Contributor
kyleknap
left a comment
There was a problem hiding this comment.
Looks good! Other than the comment on using the DenormalizedStructureBuilder, just had one more comment. It also may be worth rebasing this off of develop. It looks like there may be some merge conflicts.
Auto-generate a note for Tagged Union structures in the docs that instructs users to only set one of the possible top level keys.
3927a67 to
15472bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Services and
botocoresupport Tagged Union structures. The purpose of this PR is to enhance the CLI docs by generating a usage note for Tagged Union structures. Because Tagged Union structures can be nested under other complex types, the change needed to be made for nested options, in addition to top level options.Preview of changes:
