Skip to content

Add CodeCommit Repository Resource to cloudformation package command#5568

Merged
justindho merged 1 commit intoaws:developfrom
ConnorKirk:add-codecommit-repository-to-cloudformation-package-command
Jun 1, 2022
Merged

Add CodeCommit Repository Resource to cloudformation package command#5568
justindho merged 1 commit intoaws:developfrom
ConnorKirk:add-codecommit-repository-to-cloudformation-package-command

Conversation

@ConnorKirk
Copy link
Copy Markdown
Contributor

@ConnorKirk ConnorKirk commented Sep 24, 2020 •
edited
Loading

This commit enables the aws cloudformation package command
to package the AWS::CodeCommit::Repository resource type.

Issue #, if available:

#4316

Description of changes:
This PR enables aws cloudformation package to work with the AWS::CodeCommit::Repository resource.
Below shows an example of the input and output.

# template.yaml
  Repository:
    Type: AWS::CodeCommit::Repository
    Properties:
      RepositoryName: ExampleRepo
      Code: 
        S3: "./templates"
# packaged.yaml
  Repository:
    Type: AWS::CodeCommit::Repository
    Properties:
      RepositoryName: ExampleRepo
      Code:
        S3:
          Bucket: example-bucket
          Key: example-key/86b2583b377db47d6632369e46588f79

Testing

I have tested packaging and deploying a template with this change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 24, 2020 •
edited
Loading

Codecov Report

Merging #5568 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5568   +/-   ##
========================================
  Coverage    92.51%   92.52%           
========================================
  Files          196      196           
  Lines        15890    15898    +8     
========================================
+ Hits         14701    14709    +8     
  Misses        1189     1189
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.69% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca77732...9b984d9. Read the comment docs.

@ConnorKirk ConnorKirk changed the title Add CodeCommitRepositoryResource Add CodeCommitRepositoryResource to cloudformation package Sep 24, 2020
@ConnorKirk ConnorKirk changed the title Add CodeCommitRepositoryResource to cloudformation package Add CodeCommit Repository Resource to cloudformation package command Sep 24, 2020
stilvoid
stilvoid reviewed Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stilvoid stilvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add an entry to the documentation page too :)

@ConnorKirk ConnorKirk force-pushed the add-codecommit-repository-to-cloudformation-package-command branch from 9469f8a to b3aff2f Compare September 24, 2020 13:13
@ConnorKirk ConnorKirk closed this Sep 24, 2020
@ConnorKirk ConnorKirk force-pushed the add-codecommit-repository-to-cloudformation-package-command branch from b3aff2f to ca77732 Compare September 24, 2020 13:18
@ConnorKirk ConnorKirk reopened this Sep 24, 2020
@ConnorKirk ConnorKirk force-pushed the add-codecommit-repository-to-cloudformation-package-command branch 2 times, most recently from 2b651e5 to af217ab Compare November 23, 2020 15:44
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 23, 2020 •
edited
Loading

Codecov Report

Merging #5568 (af217ab) into develop (ca77732) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5568      +/-   ##
===========================================
+ Coverage    92.51%   92.63%   +0.12%     
===========================================
  Files          196      196              
  Lines        15890    15907      +17     
===========================================
+ Hits         14701    14736      +35     
+ Misses        1189     1171      -18
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.69% <100.00%> (+0.03%) ⬆️
awscli/paramfile.py 100.00% <0.00%> (ø)
awscli/customizations/argrename.py 100.00% <0.00%> (ø)
awscli/customizations/emr/helptext.py 100.00% <0.00%> (ø)
awscli/customizations/dlm/constants.py 100.00% <0.00%> (ø)
awscli/customizations/emr/argumentschema.py 100.00% <0.00%> (ø)
awscli/customizations/emr/createcluster.py 98.32% <0.00%> (+0.01%) ⬆️
awscli/customizations/s3/utils.py 98.12% <0.00%> (+0.02%) ⬆️
awscli/customizations/dlm/createdefaultrole.py 94.91% <0.00%> (+0.08%) ⬆️
awscli/help.py 96.98% <0.00%> (+0.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca77732...af217ab. Read the comment docs.

@kdaily kdaily added cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) labels Mar 19, 2021
@justindho justindho linked an issue May 31, 2022 that may be closed by this pull request
Support for AWS::CodeCommit::Repository in aws cloudformation package #4316
Closed
@ConnorKirk @justindho
Add CodeCommit::Repository to cfn package command
e6f1329 
This commit adds the CodeCommitRepositoryS3Resource. This enables
`aws cloudformation package` to work with the CodeCommit repository
resource type
@justindho justindho force-pushed the add-codecommit-repository-to-cloudformation-package-command branch from af217ab to e6f1329 Compare June 1, 2022 00:01
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #5568 (e6f1329) into develop (9b940e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5568   +/-   ##
========================================
  Coverage    92.88%   92.88%           
========================================
  Files          204      204           
  Lines        16336    16344    +8     
========================================
+ Hits         15173    15181    +8     
  Misses        1163     1163
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.72% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b940e8...e6f1329. Read the comment docs.

justindho
justindho approved these changes Jun 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@justindho justindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ConnorKirk!

@justindho justindho merged commit eab8942 into aws:develop Jun 1, 2022
@justindho justindho mentioned this pull request Jun 1, 2022
Closed
@justindho justindho added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jun 1, 2022
@ConnorKirk ConnorKirk deleted the add-codecommit-repository-to-cloudformation-package-command branch June 1, 2022 08:12
@ConnorKirk
Copy link
Copy Markdown
Contributor Author

ConnorKirk commented Jun 1, 2022

Thanks @justindho 🥳

@justindho justindho added released and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stilvoid stilvoid stilvoid left review comments

@justindho justindho justindho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cloudformation package-deploy cloudformation contribution:core This is a PR that came from AWS. customization Issues related to CLI customizations (located in /awscli/customizations) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for AWS::CodeCommit::Repository in aws cloudformation package

7 participants

@ConnorKirk @codecov-commenter @codecov-io @stilvoid @justindho @kdaily @RyanFitzSimmonsAK