Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4353 +/- ##
==========================================
- Coverage 94.5% 94.5% -0.01%
==========================================
Files 188 188
Lines 14166 14158 -8
==========================================
- Hits 13388 13380 -8
Misses 778 778
Continue to review full report at Codecov.
|
This loop does not use key in dict.
This loop does not use key in dict.
This variable is not used, And can reduce the else statement.
This variable is not used, And can reduce the if statement.
This variable is not used, And can reduce the if statement and for statement.
49c7fb4 to
563a75b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4353 +/- ##
===========================================
- Coverage 92.88% 92.87% -0.01%
===========================================
Files 204 204
Lines 16336 16329 -7
===========================================
- Hits 15173 15166 -7
Misses 1163 1163
Continue to review full report at Codecov.
|
justindho
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused variables.
This will lead to a slight performance improvement.