Skip to content

Added missing --user-attributes flag#4135

Merged
justindho merged 1 commit intoaws:developfrom
aamirmushtaq:cognito-documentation-fix
May 19, 2022
Merged

Added missing --user-attributes flag#4135
justindho merged 1 commit intoaws:developfrom
aamirmushtaq:cognito-documentation-fix

Conversation

@aamirmushtaq
Copy link
Copy Markdown

@aamirmushtaq aamirmushtaq commented May 7, 2019

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aamirmushtaq
Copy link
Copy Markdown
Author

aamirmushtaq commented May 7, 2019

Found the flag was missing to add the user attributes

➜  /Users/<myuser>/codebase/aws-cli (cognito-documentation-fix) ✔ aws --version
aws-cli/1.16.100 Python/3.7.2 Darwin/18.5.0 botocore/1.12.90

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 7, 2019 •
edited
Loading

Codecov Report

Merging #4135 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4135   +/-   ##
========================================
  Coverage    94.46%   94.46%           
========================================
  Files          187      187           
  Lines        14121    14121           
========================================
  Hits         13340    13340           
  Misses         781      781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950126b...0d1f8f9. Read the comment docs.

@aamirmushtaq
Copy link
Copy Markdown
Author

aamirmushtaq commented Jul 5, 2019

Is this in yet?

@kdaily
Copy link
Copy Markdown
Member

kdaily commented Oct 20, 2021

Apologies for the delay, @aamirmushtaq. It does look like this change was subsequently fixed, but inadvertently added an extra space. I've rebased your change and we can pull it in to fix that. Thanks!

@kdaily kdaily added documentation This is a problem with documentation. pr:ready-to-merge This PR is ready to be merged. labels Oct 20, 2021
@justindho justindho force-pushed the cognito-documentation-fix branch from eafcdae to a9bd9fa Compare May 19, 2022 20:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2022

Codecov Report

Merging #4135 (eafcdae) into develop (c5063fc) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head eafcdae differs from pull request most recent head a9bd9fa. Consider uploading reports for the commit a9bd9fa to get more accurate results

@@             Coverage Diff             @@
##           develop    #4135      +/-   ##
===========================================
- Coverage    92.88%   92.84%   -0.04%     
===========================================
  Files          204      204              
  Lines        16337    16293      -44     
===========================================
- Hits         15174    15128      -46     
- Misses        1163     1165       +2
Impacted Files Coverage Δ
.../customizations/datapipeline/createdefaultroles.py 84.72% <0.00%> (-1.00%) ⬇️
awscli/utils.py 94.38% <0.00%> (-0.92%) ⬇️
awscli/customizations/configure/writer.py 99.04% <0.00%> (-0.10%) ⬇️
awscli/customizations/emr/createcluster.py 98.34% <0.00%> (-0.02%) ⬇️
awscli/customizations/emr/helptext.py 100.00% <0.00%> (ø)
awscli/customizations/eks/get_token.py 100.00% <0.00%> (ø)
awscli/customizations/emr/describecluster.py 93.61% <0.00%> (ø)
awscli/customizations/cloudformation/deploy.py 100.00% <0.00%> (ø)
awscli/customizations/eks/update_kubeconfig.py 97.93% <0.00%> (ø)
awscli/customizations/cloudformation/deployer.py 96.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5063fc...a9bd9fa. Read the comment docs.

justindho
justindho approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@justindho justindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aamirmushtaq Thanks for the contribution!

@justindho justindho merged commit 469d03c into aws:develop May 19, 2022
@justindho justindho added pending-release This issue will be fixed by an approved PR that hasn't been released yet. community released and removed pr:ready-to-merge This PR is ready to be merged. pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justindho justindho justindho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community documentation This is a problem with documentation. released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aamirmushtaq @codecov-io @kdaily @codecov-commenter @justindho @RyanFitzSimmonsAK