Fix huge slowdown in generating neighbors#127
Merged
mfeurer merged 1 commit intoautoml:masterfrom Sep 30, 2019
Merged
Conversation
The unnecessary calls to `np.any()` caused a huge slowdown in generating neighbors in SMAC. See automl/SMAC3#540. I added a check to see if this call is needed.
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 19 19
Lines 1799 1799
=======================================
Hits 1201 1201
Misses 598 598Continue to review full report at Codecov.
|
Contributor
|
Thanks a lot, this even makes the unit tests faster! |
This was referenced Mar 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnecessary calls to
np.any()caused a huge slowdown in generating neighbors in SMAC. See automl/SMAC3#540. I added a check to see if this call is needed.