This repository was archived by the owner on Nov 22, 2018. It is now read-only.
fix : DefaultFilesMiddleware serve with unicode path#257
Merged
Tratcher merged 2 commits intoaspnet:release/2.2from Oct 17, 2018
Merged
fix : DefaultFilesMiddleware serve with unicode path#257Tratcher merged 2 commits intoaspnet:release/2.2from
Tratcher merged 2 commits intoaspnet:release/2.2from
Conversation
- check path by PathString.Value - add test address #3633
|
|
poke
reviewed
Oct 17, 2018
poke
left a comment
There was a problem hiding this comment.
Could you please run the code formatter in the test file? There are a few minor nits that should get fixed that way.
Btw. you don’t need to create a new pull request; you can just commit and push to your branch to update the PR.
format the file of `DefaultFilesMiddlewares.cs`
Contributor
Author
|
@poke Sorry for the inconvenience . I didn't realize I should format the code. |
Tratcher
approved these changes
Oct 17, 2018
Member
|
Thank you. |
Contributor
Author
|
@Tratcher I would like to thank you too for giving me a chance to participate in the development :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #3633