[MJAVADOC-538] Filter out 'Picked up'#11
Merged
rfscholte merged 1 commit intoapache:masterfrom Nov 19, 2018
Merged
Conversation
|
FWIW, I can confirm this solves the problem in my project. Thanks! |
edd1c8c to
b0bee92
Compare
Contributor
Author
|
Added integration test. |
rfscholte
requested changes
Nov 18, 2018
Contributor
rfscholte
left a comment
There was a problem hiding this comment.
Just a couple of small things to improve, almost there.
b0bee92 to
3738762
Compare
Contributor
Author
|
@rfscholte Addressed your review comments. Thanks! |
Contributor
|
One final request: add yourself as contributor to the root |
Signed-off-by: Kevin Risden <krisden@apache.org>
3738762 to
c05e8dc
Compare
Contributor
Author
|
@rfscholte added myself as contributor. Let me know if there is anything else :) |
Contributor
|
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-javadoc-plugin/job/MJAVADOC-538/ |
|
Resolve #807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with:
mvn -Prun-its verifyAdditional testing on project I was having original issues
mvn installexport JAVA_TOOL_OPTIONS="-Dapple.awt.UIElement=true"mvn -Dmaven.javadoc.failOnError=true -Dmaven.javadoc.failOnWarnings=true javadoc:javadoc javadoc:test-javadocPrior to this change was getting failure from warning "Picked up ...". With this change, Javadoc no longer fails due to warning.