Add withErrorHandler feature to provideRouter#48551
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
Add withErrorHandler feature to provideRouter#48551atscott wants to merge 2 commits intoangular:mainfrom
withErrorHandler feature to provideRouter#48551atscott wants to merge 2 commits intoangular:mainfrom
Conversation
alfaproject
reviewed
Dec 20, 2022
52f01f9 to
929be8d
Compare
929be8d to
f89e13c
Compare
`withNavigationErrorHandler` is a close replacement for the `RouterModule.forRoot.errorHandler` / `Router.errorHandler`. It provides a quick, short way for users to define a function to handle `NavigationError` events.
f89e13c to
981807d
Compare
AndrewKushnir
approved these changes
Dec 22, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM with one comment about an alias 👍
`errorHandler` and `malformedUriErrorHandler` were already deprecated in the Router class public API. This change updates the deprecation to extend to `RouterModule.forRoot` configuration options.
981807d to
e89378e
Compare
AndrewKushnir
approved these changes
Dec 22, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
dylhunn
approved these changes
Dec 27, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
pkozlowski-opensource
approved these changes
Jan 2, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Contributor
Author
|
merge assistance: Nothing is failing but checks aren't completing |
Member
|
This PR was merged into the repository by commit 15eccef. |
alxhub
pushed a commit
that referenced
this pull request
Jan 5, 2023
`errorHandler` and `malformedUriErrorHandler` were already deprecated in the Router class public API. This change updates the deprecation to extend to `RouterModule.forRoot` configuration options. PR Close #48551
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…er (angular#48551) `withNavigationErrorHandler` is a close replacement for the `RouterModule.forRoot.errorHandler` / `Router.errorHandler`. It provides a quick, short way for users to define a function to handle `NavigationError` events. PR Close angular#48551
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
`errorHandler` and `malformedUriErrorHandler` were already deprecated in the Router class public API. This change updates the deprecation to extend to `RouterModule.forRoot` configuration options. PR Close angular#48551
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1:
withErrorHandleris a close replacement for theRouterModule.forRoot.errorHandler/Router.errorHandler.It provides a quick, short way for users to define a function to handle
NavigationErrorevents.Commit 2:
errorHandlerandmalformedUriErrorHandlerwere already deprecated inthe Router class public API. This change updates the deprecation to
extend to
RouterModule.forRootconfiguration options.