feat(core): Make the isStandalone() function available in public API#48114
feat(core): Make the isStandalone() function available in public API#48114JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
7b51738 to
c16e64b
Compare
There was a problem hiding this comment.
@JeanMeche thanks for the PR 👍
I've left some comments, but also wanted to propose an update to the error message:
feat(core): Make the `isStandalone()` function available in public API
This commit updates an internal `isStandalone` function and exposes it as a public API,
so that it can be used in applications code.
Fixes #48114.
Thank you.
247778b to
c5dcac7
Compare
|
@AndrewKushnir I took your suggestions into account ! |
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche thanks for addressing the feedback! I've added a few more comments.
24d63cd to
e1cc34f
Compare
39db4ad to
6cc7a8c
Compare
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche the changes look great, I'm adding an LGTM. We'd need to get a couple more approvals since this PR changes the public API surface.
There was a problem hiding this comment.
LGTM! This looks great! Thanks, @JeanMeche!
reviewed-for: public-api, fw-core
6cc7a8c to
bddbd00
Compare
This commit updates an internal `isStandalone` function and exposes it as a public API, so that it can be used in applications code. fixes angular#47919
bddbd00 to
7593c39
Compare
|
Caretaker Note: Please ignore the |
|
This PR was merged into the repository by commit 3842157. |
|
@JeanMeche thanks again for creating this PR and addressing the feedback 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
angular#48114) This commit updates an internal `isStandalone` function and exposes it as a public API, so that it can be used in applications code. fixes angular#47919 PR Close angular#48114
Making isStandalone() a public api
fixes #47919
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
ɵisStandalone)Other information
It's the first time I'm exposing a previously private API. Feedbacks are welcome !