fix(common): Don't warn about image distortion if fill mode is enabled#47824
Closed
atcastle wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): Don't warn about image distortion if fill mode is enabled#47824atcastle wants to merge 1 commit intoangular:mainfrom
atcastle wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
Oct 20, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@atcastle looks good, just a small request to add a comment into the code (see below). Thank you.
packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Outdated
Show resolved
Hide resolved
The image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox.
b8a6d84 to
a1eec0d
Compare
AndrewKushnir
approved these changes
Oct 20, 2022
Contributor
Contributor
|
This PR was merged into the repository by commit 6b9b472. |
This was referenced Oct 21, 2022
Merged
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
angular#47824) The image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox. PR Close angular#47824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) when in fill mode. The warning doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox, depending on their styling. Test is e2e only because this warning only fires after the image is loaded.