fix(router): Ensure ActivatedRouteSnapshot#title has correct value#47481
fix(router): Ensure ActivatedRouteSnapshot#title has correct value#47481atscott wants to merge 1 commit intoangular:mainfrom
Conversation
ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation. fixes angular#47459 BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
|
@atscott this PR got all the approvals but it seems like it needs a bit more work before it can land: g3 status is "failing" and I'm not sure if this is a flake or something that needs attention. Also, since this is a breaking change, it should go to one of the v15 milestones, right? |
|
@pkozlowski-opensource That's right. There is some remaining cleanup in g3 that is ongoing. |
|
TGP with internal cleanups |
|
This PR was merged into the repository by commit 6a88bad. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation.
fixes #47459
BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot