fix(common): warn if using supported CDN but not built-in loader#47330
Closed
kara wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): warn if using supported CDN but not built-in loader#47330kara wants to merge 1 commit intoangular:mainfrom
kara wants to merge 1 commit intoangular:mainfrom
Conversation
packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Outdated
Show resolved
Hide resolved
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
As @AndrewKushnir indicated, I would also see this logic going into the noop image loader.
b9f5639 to
566f6c3
Compare
AndrewKushnir
approved these changes
Oct 18, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great, thanks @kara 👍
Contributor
This commit adds a missing warning if the image directive detects that you're hosting your image on one of our supported image CDNs but you're not using the built-in loader for it. This excludes applications that are using a custom loader.
AndrewKushnir
approved these changes
Oct 18, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
|
Caretaker note (@dylhunn): this PR is ready for merge except for one more |
dylhunn
approved these changes
Oct 19, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit ce5880f. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 19, 2022
) This commit adds a missing warning if the image directive detects that you're hosting your image on one of our supported image CDNs but you're not using the built-in loader for it. This excludes applications that are using a custom loader. PR Close #47330
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…ular#47330) This commit adds a missing warning if the image directive detects that you're hosting your image on one of our supported image CDNs but you're not using the built-in loader for it. This excludes applications that are using a custom loader. PR Close angular#47330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a console warning if the image directive
detects that you're hosting your image on one of our
supported image CDNs but you're not using the built-in loader
for it. This excludes applications that are using a custom
loader.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?