refactor(localize): remove deprecated canParse method from TranslationParsers#47275
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
refactor(localize): remove deprecated canParse method from TranslationParsers#47275alan-agius4 wants to merge 1 commit intoangular:mainfrom
canParse method from TranslationParsers#47275alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
canParse method from TranslationParserscanParse method from TranslationParsers
5396926 to
7ceae0d
Compare
7b87c1c to
44cc200
Compare
514092b to
a5a2a07
Compare
a5a2a07 to
1242609
Compare
1242609 to
e7833b0
Compare
dgp1130
approved these changes
Aug 29, 2022
...tools/test/translate/translation_files/translation_parsers/xliff1_translation_parser_spec.ts
Outdated
Show resolved
Hide resolved
jessicajaniuk
approved these changes
Aug 29, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
approved these changes
Aug 29, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
e7833b0 to
737cf4f
Compare
…ionParsers This change removed the deprecated `canParse` method from all the TranslationParsers. BREAKING CHANGE: - `canParse` method has been removed from all translation parsers in `@angular/localize/tools`. `analyze` should be used instead. - the `hint` parameter in the`parse` methods is now mandatory.
737cf4f to
a974932
Compare
Contributor
|
This PR was merged into the repository by commit d36fd3d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removed the deprecated
canParsemethod from all the TranslationParsers.BREAKING CHANGE:
canParsemethod has been removed from all translation parsers in@angular/localize/tools.analyzeshould be used instead.hintparameter in theparsemethods is now mandatory.