fix(router): Use correct return type for provideRoutes function#46941
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): Use correct return type for provideRoutes function#46941atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
The provideRoutes function of the Router returns a Provider array and should not be typed as 'any'
Contributor
Author
AndrewKushnir
approved these changes
Jul 22, 2022
AndrewKushnir
approved these changes
Jul 22, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jul 22, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
DarkSeidNG
approved these changes
Jul 29, 2022
Contributor
|
This PR was merged into the repository by commit f364378. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 1, 2022
The provideRoutes function of the Router returns a Provider array and should not be typed as 'any' PR Close #46941
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Aug 9, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.0/14.1.1) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.0/14.1.1) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.0/14.1.1) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.0/14.1.1) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.0/14.1.1) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.0/14.1.1) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.0/14.1.1) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.1.0` -> `14.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.0/14.1.1) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1411-2022-08-03) [Compare Source](angular/angular@14.1.0...14.1.1) ##### core | Commit | Type | Description | | -- | -- | -- | | [3606917732](angular/angular@3606917) | fix | improve the missing control flow directive message ([#​46903](angular/angular#46903)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [79825d3f10](angular/angular@79825d3) | fix | Do not call preload method when not necessary ([#​47007](angular/angular#47007)) | | [05f3f7445a](angular/angular@05f3f74) | fix | Use correct return type for provideRoutes function ([#​46941](angular/angular#46941)) | #### Special Thanks Alan Agius, Andrew Kushnir, Andrew Quinn, Andrew Scott, Aristeidis Bampakos, Asaf M, Bob Watson, Cédric Exbrayat, Durairaj Subramaniam, George Kalpakas, Ivaylo Kirov, J Rob Gant, Kristiyan Kostadinov, Marek Hám, Paul Gschwendtner, Roman Matusevich and Simona Cotin <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1490 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This was referenced Aug 9, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provideRoutes function of the Router returns a Provider array and should not be typed as 'any'
Note: need to run global presubmit to determine if this needs to be considered a breaking change. Generally these type changes are, but due to the nature of how this is likely to be used, it's possible it won't need to be.TGP came back green for this change so it should be safe to land in patch (or minor if we want to be more conservative).