perf(bazel): use allowedInputs to avoid fs.stat#46069
Closed
frigus02 wants to merge 1 commit intoangular:mainfrom
Closed
perf(bazel): use allowedInputs to avoid fs.stat#46069frigus02 wants to merge 1 commit intoangular:mainfrom
frigus02 wants to merge 1 commit intoangular:mainfrom
Conversation
Call tsc_wrapped's fileExists function instead of TypeScript's. tsc_wrapped (used internally by ngc-wrapped) has an optimization under bazel to avoid file system calls where possible. It takes advantage bazelOpts.allowedInputs, which contains a list of all files available for compilation. File system calls can be quite slow depending on the file system. In google3 I saw a 38 seconds compilation, which spent 6 seconds just doing fs.stat calls during module resolution. Those fs.stat calls are entirely gone after with this change.
Contributor
Author
|
Here are screenshots of a CPU profile before and after the change:
More details are in an internal ticket: http://b/232199273#comment2 |
devversion
approved these changes
May 20, 2022
Member
|
Presubmit: cl/449952536 (we want to wait for a TGP) |
Member
|
This PR was merged into the repository by commit 7efa09b. |
alxhub
pushed a commit
that referenced
this pull request
May 24, 2022
Call tsc_wrapped's fileExists function instead of TypeScript's. tsc_wrapped (used internally by ngc-wrapped) has an optimization under bazel to avoid file system calls where possible. It takes advantage bazelOpts.allowedInputs, which contains a list of all files available for compilation. File system calls can be quite slow depending on the file system. In google3 I saw a 38 seconds compilation, which spent 6 seconds just doing fs.stat calls during module resolution. Those fs.stat calls are entirely gone after with this change. PR Close #46069
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Regarding tests: Do you have a way to test for file system calls during compilation?
PR Type
What is the current behavior?
ngc-wrapped calls TypeScript's fileExists function during module resolution, which calls fs.statSync.
File system calls can be quite slow depending on the file system. In google3 I saw a 38 seconds compilation, which spent 6 seconds just doing fs.stat calls during module resolution.
What is the new behavior?
Call tsc_wrapped's fileExists function instead of TypeScript's.
tsc_wrapped (used internally by ngc-wrapped) has an optimization under bazel to avoid file system calls where possible. It takes advantage bazelOpts.allowedInputs, which contains a list of all files available for compilation.
The fs.stat calls mentioned for the slow google3 target are entirely gone after with this change.
Does this PR introduce a breaking change?