fix(compiler-cli): handle forwardRef in imports of standalone component#45869
fix(compiler-cli): handle forwardRef in imports of standalone component#45869crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
left a comment
There was a problem hiding this comment.
I think it would be worthwhile to capture this in a compliance test, as we'd then get a golden file for the partial compilation output and a round-trip with the linker.
There was a problem hiding this comment.
nit: wonder what is going on with the formatting in here? Did a "badly" formatted file end up in the repo? Or is your formatter config off?
Generally speaking I would love to avoid unnecessary diffs (harder to review, potential for a merge conflict etc. etc.)
There was a problem hiding this comment.
It's because we aren't enforcing trailing whitespaces. I have a setting in my IDE to trim them automatically.
There was a problem hiding this comment.
As you should per .editorconfig: https://github.com/angular/angular/blob/main/.editorconfig#L11
I've tried to add a linting rule years ago for this and line ending at the end of the file that keeps changing on every file depending on who edits it and it's been annoying for years, but at the time, vicb told me that it's better to allow people do their own thing. I fail to see why, but I'm not a maintainer, ofc
There was a problem hiding this comment.
Technically your editor is in the wrong here, as these are multi-line template strings and thus trailing whitespace on a line is load-bearing (it's part of the string contents), definitely not spurious.
Fixes that the compiler wasn't resolving `forwardRef` values when they're used in the `imports` of a standalone component.
4a43f68 to
b7c40dd
Compare
|
I've added a compliance test. |
|
This PR was merged into the repository by commit 32c625d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that the compiler wasn't resolving
forwardRefvalues when they're used in theimportsof a standalone component.