fix(ngcc): cope with packages following APF v14+ by gkalpak · Pull Request #45833 · angular/angular

gkalpak · 2022-04-30T17:25:12Z

In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as @angular/common/http) do not have their own package.json file, as they used to. Instead, the paths to their various formats and types are exposed via the primary package.json file's exports property. As an example, see the v13 @angular/common/http/package.json and compare it with the v14 @angular/common/package.json > exports.

Previously, ngcc was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing.

This commit addresses the issue by detecting this situation and synthesizing a package.json file for the secondary entry-points based on the exports property of the primary package.json file. This data is only used by ngcc in order to determine that the entry-point does not need further processing, since it is already in Ivy format.

FYI, I have tested this on ngcc-validation and it makes CI green: CI run

mary-poppins · 2022-04-30T17:35:00Z

You can preview cda0f67 at https://pr45833-cda0f67.ngbuilds.io/.

mary-poppins · 2022-04-30T21:02:18Z

You can preview c92207d at https://pr45833-c92207d.ngbuilds.io/.

mary-poppins · 2022-04-30T21:15:00Z

You can preview 330569e at https://pr45833-330569e.ngbuilds.io/.

mary-poppins · 2022-05-03T13:36:41Z

You can preview 7c75b0b at https://pr45833-7c75b0b.ngbuilds.io/.

mary-poppins · 2022-05-03T15:04:07Z

You can preview 1ab8b94 at https://pr45833-1ab8b94.ngbuilds.io/.

mary-poppins · 2022-05-03T19:43:28Z

You can preview d4c3a78 at https://pr45833-d4c3a78.ngbuilds.io/.

JoostK

Nice work!

packages/compiler-cli/ngcc/src/dependencies/module_resolver.ts

packages/compiler-cli/ngcc/src/utils.ts

packages/compiler-cli/ngcc/test/utils_spec.ts

Remove some unused dependencies from `ngcc` source code.

Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies.

In PR angular#45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json

JoostK

LGTM

mary-poppins · 2022-05-05T20:08:46Z

You can preview 3686a06 at https://pr45833-3686a06.ngbuilds.io/.

AndrewKushnir · 2022-05-06T16:51:19Z

This PR was merged into the repository by commit d4e949f.

…ts` (#45833) Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies. PR Close #45833

In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json PR Close #45833

Remove some unused dependencies from `ngcc` source code. PR Close #45833

…ts` (#45833) Move the `loadPackageJson()` helper (and associated generic types, such as `JsonObject`) from `packages/entry_point.ts` to `utils.ts` and also rename it to `loadJson()`. This way, they can be used in other places in future commits, without introducing cyclical dependencies. PR Close #45833

In PR #45405, the Angular Package Format (APF) was updated so that secondary entry-points (such as `@angular/common/http`) do not have their own `package.json` file, as they used to. Instead, the paths to their various formats and types are exposed via the primary `package.json` file's `exports` property. As an example, see the v13 [@angular/common/http/package.json][1] and compare it with the v14 [@angular/common/package.json > exports][2]. Previously, `ngcc` was not able to analyze such v14+ entry-points and would instead error as it considered such entry-points missing. This commit addresses the issue by detecting this situation and synthesizing a `package.json` file for the secondary entry-points based on the `exports` property of the primary `package.json` file. This data is only used by `ngcc` in order to determine that the entry-point does not need further processing, since it is already in Ivy format. [1]: https://unpkg.com/browse/@angular/common@13.3.5/http/package.json [2]: https://unpkg.com/browse/@angular/common@14.0.0-next.15/package.json PR Close #45833

angular-automatic-lock-bot · 2022-06-06T16:06:21Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak added type: bug/fix state: WIP comp: ngcc target: minor This PR is targeted for the next minor release labels Apr 30, 2022

ngbot bot modified the milestone: Backlog Apr 30, 2022

gkalpak changed the title ~~WIP - fix(ngcc): cope with packages following APF v14+~~ fix(ngcc): cope with packages following APF v14+ Apr 30, 2022

gkalpak mentioned this pull request Apr 30, 2022

Test PR angular/angular#45833 angular/ngcc-validation#6245

Closed

gkalpak force-pushed the fix-ngcc-apf-v14 branch from cda0f67 to c92207d Compare April 30, 2022 20:53

gkalpak force-pushed the fix-ngcc-apf-v14 branch from c92207d to 330569e Compare April 30, 2022 21:04

gkalpak force-pushed the fix-ngcc-apf-v14 branch from 330569e to 7c75b0b Compare May 3, 2022 13:27

gkalpak added a commit to gkalpak/ngcc-validation that referenced this pull request May 3, 2022

TEST PR angular/angular#45833

4670f69

gkalpak added a commit to gkalpak/ngcc-validation that referenced this pull request May 3, 2022

TEST PR angular/angular#45833

5eed25c

gkalpak force-pushed the fix-ngcc-apf-v14 branch from 7c75b0b to 1ab8b94 Compare May 3, 2022 14:54

gkalpak force-pushed the fix-ngcc-apf-v14 branch from 1ab8b94 to d4c3a78 Compare May 3, 2022 19:34

gkalpak added a commit to gkalpak/ngcc-validation that referenced this pull request May 3, 2022

TEST PR angular/angular#45833

196a0f3

gkalpak marked this pull request as ready for review May 3, 2022 20:08

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels May 3, 2022

JoostK self-requested a review May 3, 2022 20:23

JoostK reviewed May 4, 2022

View reviewed changes

packages/compiler-cli/ngcc/src/dependencies/module_resolver.ts Outdated Show resolved Hide resolved

packages/compiler-cli/ngcc/src/utils.ts Outdated Show resolved Hide resolved

packages/compiler-cli/ngcc/test/utils_spec.ts Outdated Show resolved Hide resolved

gkalpak added 3 commits May 5, 2022 21:48

refactor(ngcc): remove unused dependencies

592a1af

Remove some unused dependencies from `ngcc` source code.

gkalpak force-pushed the fix-ngcc-apf-v14 branch from d4c3a78 to 3686a06 Compare May 5, 2022 19:59

fixup! fix(ngcc): cope with packages following APF v14+

3686a06

gkalpak requested a review from JoostK May 5, 2022 20:01

JoostK approved these changes May 5, 2022

View reviewed changes

JoostK added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels May 5, 2022

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2022

AndrewKushnir closed this in 8467e9a May 6, 2022

AndrewKushnir pushed a commit that referenced this pull request May 6, 2022

refactor(ngcc): remove unused dependencies (#45833)

06bfcb2

Remove some unused dependencies from `ngcc` source code. PR Close #45833

gkalpak deleted the fix-ngcc-apf-v14 branch May 6, 2022 17:31

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngcc): cope with packages following APF v14+#45833

fix(ngcc): cope with packages following APF v14+#45833
gkalpak wants to merge 4 commits intoangular:mainfrom
gkalpak:fix-ngcc-apf-v14

gkalpak commented Apr 30, 2022 •

edited

Loading

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

JoostK left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoostK left a comment

Uh oh!

mary-poppins commented May 5, 2022

Uh oh!

AndrewKushnir commented May 6, 2022

Uh oh!

angular-automatic-lock-bot bot commented Jun 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gkalpak commented Apr 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented Apr 30, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

mary-poppins commented May 3, 2022

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented May 5, 2022

Uh oh!

AndrewKushnir commented May 6, 2022

Uh oh!

angular-automatic-lock-bot bot commented Jun 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gkalpak commented Apr 30, 2022 •

edited

Loading