fix(compiler-cli): report invalid imports in standalone components during resolve phase#45827
Closed
JoostK wants to merge 2 commits intoangular:mainfrom
Closed
fix(compiler-cli): report invalid imports in standalone components during resolve phase#45827JoostK wants to merge 2 commits intoangular:mainfrom
JoostK wants to merge 2 commits intoangular:mainfrom
Conversation
…ring resolve phase The analysis phase of the compiler should operate on individual classes, independently of the analysis of other classes. The validation that `Component.imports` only contains standalone entities or NgModules however did happen during the analysis phase, introducing a dependency on other classes and causing inconsistencies due to ordering and/or asynchronous timing differences. This commit fixes the issue by moving the validation to the resolve phase, which occurs after all classes have been analyzed. Fixes angular#45819
Changes the message from: ``` The component 'HelloComponent' appears in 'imports', but is not standalone and cannot be imported directly It must be imported via an NgModule. ``` to ``` The component 'HelloComponent' appears in 'imports', but is not standalone and cannot be imported directly. It must be imported via an NgModule. ```
0bc2af5 to
03b24e4
Compare
alxhub
approved these changes
May 2, 2022
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
Contributor
Contributor
|
This PR was merged into the repository by commit 3ebf9e7. |
dylhunn
pushed a commit
that referenced
this pull request
May 2, 2022
Changes the message from: ``` The component 'HelloComponent' appears in 'imports', but is not standalone and cannot be imported directly It must be imported via an NgModule. ``` to ``` The component 'HelloComponent' appears in 'imports', but is not standalone and cannot be imported directly. It must be imported via an NgModule. ``` PR Close #45827
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analysis phase of the compiler should operate on individual classes, independently
of other the analysis of other classes. The validation that
Component.importsonlycontains standalone entities or NgModules however did happen during the analysis phase,
introducing a dependency on other classes and causing inconsistencies due to ordering
and/or asynchronous timing differences.
This commit fixes the issue by moving the validation to the resolve phase, which occurs
after all classes have been analyzed.
Fixes #45819