fix(core): prevent BrowserModule providers from being loaded twice#45826
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): prevent BrowserModule providers from being loaded twice#45826AndrewKushnir wants to merge 1 commit intoangular:mainfrom
BrowserModule providers from being loaded twice#45826AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
89b1ab3 to
278bd51
Compare
Contributor
Author
packages/platform-browser/test/browser/bootstrap_standalone_spec.ts
Outdated
Show resolved
Hide resolved
alfaproject
reviewed
May 2, 2022
b1f5e26 to
29cafa3
Compare
This commit updates the logic of the `BrowserModule` to detect a situation when it's used in the `bootstrapApplication` case, which already includes `BrowserModule` providers.
822315f to
869f7f0
Compare
Contributor
Author
| afterEach(() => { | ||
| destroyPlatform(); | ||
| rootEl.remove(); | ||
| rootEl?.remove(); |
Member
There was a problem hiding this comment.
nit / question not related to this PR: I'm curious why do we see this change?
pkozlowski-opensource
approved these changes
May 3, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM, thnx so much for addressing all the review feedback!
dylhunn
approved these changes
May 3, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
pkozlowski-opensource
approved these changes
May 3, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
atscott
approved these changes
May 3, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit fa755b2. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic of the
BrowserModuleto detect a situation when it's used in thebootstrapApplicationcase, which already includesBrowserModuleproviders.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?