fix(core): throw if standalone components are present in @NgModule.bootstrap#45825
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): throw if standalone components are present in @NgModule.bootstrap#45825AndrewKushnir wants to merge 1 commit intoangular:mainfrom
@NgModule.bootstrap#45825AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
28bba7a to
39db1f2
Compare
39db1f2 to
b5358a4
Compare
Contributor
Author
alfaproject
reviewed
May 2, 2022
b5358a4 to
6ae126a
Compare
dylhunn
previously approved these changes
May 2, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
…ootstrap` This commit updates the logic to detect a situation when a standalone component is used in the NgModule-based bootstrap (`@NgModule.bootstrap`). Both AOT and JIT compilers are updated to handle this situation.
6ae126a to
93d94bd
Compare
atscott
approved these changes
May 2, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
Merge-assistance: the scope of the |
93d94bd
Contributor
|
This PR was merged into the repository by commit fde4942. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic to detect a situation when a standalone component is used in the NgModule-based bootstrap (
@NgModule.bootstrap). Both AOT and JIT compilers are updated to handle this situation.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?