fix(core): support nested arrays of providers in EnvironmentInjector#45789
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
fix(core): support nested arrays of providers in EnvironmentInjector#45789AndrewKushnir wants to merge 1 commit intoangular:masterfrom
EnvironmentInjector#45789AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
This commit updates the `EnvironmentInjector` logic to support arrays of providers as an argument(for example, when an injector is created via `createEnvironmentInjector` function).
| const A = new InjectionToken('A'); | ||
| const B = new InjectionToken('B'); | ||
| const C = new InjectionToken('C'); | ||
| const MULTI = new InjectionToken('D'); |
There was a problem hiding this comment.
super nit: name it 'MULTI' as well? I was a bit confused seeing 'D' here. Feel free to ignore.
pkozlowski-opensource
approved these changes
Apr 28, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM generally speaking. Still, I wonder if we shouldn't add more tests to the actual public APIs where an env injector is created (ex. bootstrapApplication). WDYT?
Contributor
|
This PR was merged into the repository by commit 4e413d9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the
EnvironmentInjectorlogic to support arrays of providers as an argument (for example, when an injector is created viacreateEnvironmentInjectorfunction).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?