feat(common): add Image directive skeleton#45627
feat(common): add Image directive skeleton#45627AndrewKushnir merged 1 commit intoangular:image-directivefrom
Conversation
2ca96c7 to
edfa78d
Compare
392f54f to
8977e04
Compare
|
Thnx for putting this skeleton together @AndrewKushnir . Left a couple of comments (or more of items to be discussed). But more importantly I would personally prefer that we don't add all the
This is would be my personal preference, TBD |
4d053e7 to
c72d14e
Compare
|
@kara @pkozlowski-opensource thanks for the feedback. I've applied the necessary changes, will get CI to a "green" state and proceed with merging this PR to the |
c72d14e to
c925826
Compare
There was a problem hiding this comment.
Question: do we actually want to specify a loader on the per-instance basis?
There was a problem hiding this comment.
Good question: I think this gives a nice flexibility, but I'm not sure if it'd be useful in practice. I'll keep it for now and if the decision is to drop it, I can create a followup PR.
There was a problem hiding this comment.
Hmmm, I would prefer that, in the future, we drop / don't include parts that we are unsure about, just to reduce "noise".
There was a problem hiding this comment.
I agree :)
It was a part of the doc and since we support image loaders via a token, I consider that extra option to be inline with the overall direction, so I decided to leave it (and I'm happy to update the code if we decide that it's not useful at all).
This commit adds Image directive skeleton as well as a set of basic tests.
c925826 to
5dc6d79
Compare
This commit adds Image directive skeleton as well as a set of basic tests.
This commit adds Image directive skeleton as well as a set of basic tests.
This commit adds Image directive skeleton as well as a set of basic tests.
This commit adds Image directive skeleton as well as a set of basic tests.
This commit adds Image directive skeleton as well as a set of basic tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds Image directive skeleton as well as a set of basic tests.
// cc @kara @pkozlowski-opensource
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?