feat(core): add ApplicationRef.destroy method#45624
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
feat(core): add ApplicationRef.destroy method#45624AndrewKushnir wants to merge 1 commit intoangular:masterfrom
ApplicationRef.destroy method#45624AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
93c9643 to
13dfa8b
Compare
Contributor
Author
|
Presubmit (TGP). |
13dfa8b to
5e94964
Compare
AndrewKushnir
commented
Apr 14, 2022
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: the payload size in this PR is expected (due to extra non-tree-shakable code that was added). It's ~350 bytes and the rest was accumulated already from other changes.
atscott
approved these changes
Apr 14, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking, public-api
dylhunn
approved these changes
Apr 14, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, size-tracking
jessicajaniuk
approved these changes
Apr 14, 2022
e2dfb62 to
43e9f67
Compare
43e9f67 to
2ebd2b0
Compare
Contributor
Author
2ebd2b0 to
ae66f3c
Compare
ae66f3c to
819558c
Compare
alxhub
approved these changes
Apr 16, 2022
a343cb0 to
acaa26c
Compare
alxhub
reviewed
Apr 18, 2022
packages/core/src/application_ref.ts
Outdated
Member
There was a problem hiding this comment.
Rather than track this._destroyed, we should delegate to injector.destroyed.
alxhub
approved these changes
Apr 18, 2022
936b555 to
8b30b0f
Compare
This commit implements the `destroy` method on the `ApplicationRef` class. This feature is a preparation for the new logic to bootstrap (and teardown) standalone components (without going through the `NgModuleRef` destroy), which would return an instance of the `ApplicationRef` (the current bootstrap APIs return an instance of the `NgModuleRef`).
8b30b0f to
3cf03fe
Compare
Contributor
Author
|
Presubmit after the rebase. |
Contributor
|
This PR was merged into the repository by commit 174ce7d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the
destroymethod on theApplicationRefclass. This feature is a preparation for the new logic to bootstrap (and teardown) standalone components (without going through theNgModuleRefdestroy), which would return an instance of theApplicationRef(the current bootstrap APIs return an instance of theNgModuleRef).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?