fix(bazel): do not error if files part of srcs are outside of package#45622
Closed
devversion wants to merge 1 commit intoangular:masterfrom
Closed
fix(bazel): do not error if files part of srcs are outside of package#45622devversion wants to merge 1 commit intoangular:masterfrom
srcs are outside of package#45622devversion wants to merge 1 commit intoangular:masterfrom
Conversation
We recently refactored how the ng package rule deals with static files. As part of this refactoring, transitive files outside of the current Bazel package were flagged as errors, while previously this was just ignored. We need to revert back this behavior (even though code remains much simpler and predicable now) since sass library targets for example reference all transtive files in the default info and break packages then
Contributor
|
This PR was merged into the repository by commit f8a1ea0. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently refactored how the ng package rule deals with static files.
As part of this refactoring, transitive files outside of the current
Bazel package were flagged as errors, while previously this was just
ignored. We need to revert back to this behavior (even though code remains
much simpler and predicable now) since sass library targets for example
reference all transitive files in the default info and break package composition then