fix(forms): Fix a minor error: pendingValue is a value, not a boolean flag.#44450
Closed
dylhunn wants to merge 1 commit intoangular:masterfrom
Closed
fix(forms): Fix a minor error: pendingValue is a value, not a boolean flag.#44450dylhunn wants to merge 1 commit intoangular:masterfrom
dylhunn wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
Running presubmit: http://test/OCL:416066118:BASE:416066148:1639417585696:e732db0f |
d2e4135 to
ff9de4f
Compare
… is a value not a boolean flag. The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.
ff9de4f to
a4394f2
Compare
Member
|
This PR was merged into the repository by commit 815d4ce. |
This was referenced Jan 1, 2022
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a minor error: pendingValue is a value, not a boolean flag.
The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
_pendingValuehas the wrong type. This is an internal-only type with no consequences.Issue Number: N/A
What is the new behavior?
_pendingValuehas the right type (any).Does this PR introduce a breaking change?
Other information