Skip to content

feat(core): add migration to remove entryComponents#44308

Closed
crisbeto wants to merge 1 commit intoangular:masterfrom
crisbeto:entry-components-migration
Closed

feat(core): add migration to remove entryComponents#44308
crisbeto wants to merge 1 commit intoangular:masterfrom
crisbeto:entry-components-migration

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 30, 2021

Adds an automated migration that will drop any usages of entryComponents from @NgModule and @Component.

@google-cla google-cla bot added the cla: yes label Nov 30, 2021
@crisbeto crisbeto marked this pull request as ready for review November 30, 2021 10:13
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Nov 30, 2021
@ngbot ngbot bot added this to the Backlog milestone Nov 30, 2021
@crisbeto crisbeto requested a review from devversion November 30, 2021 10:14
devversion
devversion approved these changes Nov 30, 2021
View reviewed changes
packages/core/schematics/migrations.json Outdated
Copy link
Member

@devversion devversion Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: ng update is rarely used for updating minors based on what I saw. Are we planning on re-running this for v14 major?

Copy link
Member Author

@crisbeto crisbeto Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. I suppose that I'll just have to bump the version here when we're close to 14?

Copy link
Member

@devversion devversion Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could already have a second entry for v14 and keep the 13.1.0-one as well. Not feeling strongly though.

Copy link
Member Author

@crisbeto crisbeto Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've added the second entry.

@crisbeto crisbeto force-pushed the entry-components-migration branch from 561c043 to 650c2ea Compare November 30, 2021 14:27
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2021
@crisbeto crisbeto modified the milestones: Backlog, v13.1 Nov 30, 2021
@crisbeto
feat(core): add migration to remove entryComponents
885dc95 
Adds an automated migration that will drop any usages of `entryComponents` from `@NgModule` and `@Component`.
@crisbeto crisbeto force-pushed the entry-components-migration branch from 650c2ea to 885dc95 Compare November 30, 2021 18:39
@dylhunn
Copy link
Contributor

dylhunn commented Nov 30, 2021

Merging by specific request -- ignoring Saucelabs checks

@dylhunn
Copy link
Contributor

dylhunn commented Nov 30, 2021

This PR was merged into the repository by commit 5dff077.

@dylhunn dylhunn closed this in 5dff077 Nov 30, 2021
dylhunn added a commit to dylhunn/angular that referenced this pull request Nov 30, 2021
@dylhunn
Revert "feat(core): add migration to remove entryComponents (angular#…
3c630da 
…44308)"

This reverts commit 5dff077.
@dylhunn dylhunn mentioned this pull request Nov 30, 2021
Closed
dylhunn added a commit that referenced this pull request Nov 30, 2021
@dylhunn
Revert "feat(core): add migration to remove entryComponents (#44308)" (…
a532040 
…#44318)

This reverts commit 5dff077.

PR Close #44318
@crisbeto crisbeto mentioned this pull request Dec 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 31, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

v13.1

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @dylhunn @devversion