docs: deprecate factory-based signature of the `downgradeModule` function by AndrewKushnir · Pull Request #44090 · angular/angular

AndrewKushnir · 2021-11-05T22:34:43Z

DEPRECATED:

The downgradeModule function calls with NgModule factories are deprecated. Please use NgModule class based downgradeModule calls instead.

Note: this PR also contains a commit from @petebacondarwin to ensure overloaded functions render correctly.

PR Type

What kind of change does this PR introduce?

Other... Please describe: deprecation of an old API.

Does this PR introduce a breaking change?

Yes
No

mary-poppins · 2021-11-08T18:35:50Z

You can preview 50f01bc at https://pr44090-50f01bc.ngbuilds.io/.

google-cla · 2021-11-09T09:20:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

petebacondarwin · 2021-11-09T09:20:47Z

@googlebot I consent.

mary-poppins · 2021-11-09T09:29:06Z

You can preview 8b68842 at https://pr44090-8b68842.ngbuilds.io/.

mary-poppins · 2021-11-09T17:43:08Z

You can preview e7e711d at https://pr44090-e7e711d.ngbuilds.io/.

aio/content/guide/deprecations.md

…tion DEPRECATED: The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead.

If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown. Also the type of overload parameters were not being escaped correctly.

mary-poppins · 2021-11-16T02:36:40Z

You can preview 3885368 at https://pr44090-3885368.ngbuilds.io/.

jelbourn

LGTM

atscott

reviewed-for: public-api

AndrewKushnir · 2021-11-16T22:22:34Z

Presubmit.

ngbot · 2021-11-17T18:23:06Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "ci/circleci: legacy-unit-tests-saucelabs" is failing
     status "pullapprove" is pending
     missing required status "cla/google"
     4 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

petebacondarwin

Reviewed-for: public-api

jessicajaniuk

LGTM 🍪

reviewed-for: public-api

AndrewKushnir · 2021-11-17T18:33:14Z

This PR was merged into the repository by commit e0c7360.

If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown. Also the type of overload parameters were not being escaped correctly. PR Close #44090

angular-automatic-lock-bot · 2021-12-18T16:06:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir added state: WIP area: upgrade Issues related to AngularJS → Angular upgrade APIs target: minor This PR is targeted for the next minor release labels Nov 5, 2021

google-cla bot added the cla: yes label Nov 5, 2021

ngbot bot modified the milestone: Backlog Nov 5, 2021

angular-robot bot added the flag: deprecation label Nov 5, 2021

AndrewKushnir added the aio: preview label Nov 6, 2021

petebacondarwin added the comp: docs label Nov 6, 2021

google-cla bot added cla: no and removed cla: yes labels Nov 9, 2021

google-cla bot added cla: yes and removed cla: no labels Nov 9, 2021

AndrewKushnir force-pushed the deprecate-downgrademodule-with-ngfactory branch from 8b68842 to e7e711d Compare November 9, 2021 17:33

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Nov 9, 2021

AndrewKushnir marked this pull request as ready for review November 9, 2021 17:35

pullapprove bot requested review from IgorMinar and gkalpak November 9, 2021 17:35

AndrewKushnir requested a review from petebacondarwin November 9, 2021 18:37

petebacondarwin approved these changes Nov 10, 2021

View reviewed changes

gkalpak approved these changes Nov 15, 2021

View reviewed changes

aio/content/guide/deprecations.md Outdated Show resolved Hide resolved

gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 15, 2021

AndrewKushnir and others added 2 commits November 15, 2021 18:27

docs: deprecate factory-based signature of the downgradeModule func…

674173a

…tion DEPRECATED: The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead.

build(docs-infra): ensure overloaded functions render correctly

3885368

If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown. Also the type of overload parameters were not being escaped correctly.

AndrewKushnir force-pushed the deprecate-downgrademodule-with-ngfactory branch from e7e711d to 3885368 Compare November 16, 2021 02:27

AndrewKushnir removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2021

AndrewKushnir requested a review from jelbourn November 16, 2021 19:57

jelbourn approved these changes Nov 16, 2021

View reviewed changes

pullapprove bot requested review from atscott, dylhunn and jessicajaniuk November 16, 2021 20:07

atscott approved these changes Nov 16, 2021

View reviewed changes

pullapprove bot requested a review from jelbourn November 16, 2021 20:15

AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 16, 2021

petebacondarwin approved these changes Nov 17, 2021

View reviewed changes

jessicajaniuk approved these changes Nov 17, 2021

View reviewed changes

AndrewKushnir closed this in dbc46d6 Nov 17, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2021

Conversation

AndrewKushnir commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Does this PR introduce a breaking change?

Uh oh!

mary-poppins commented Nov 8, 2021

Uh oh!

google-cla bot commented Nov 9, 2021

Uh oh!

petebacondarwin commented Nov 9, 2021

Uh oh!

mary-poppins commented Nov 9, 2021

Uh oh!

mary-poppins commented Nov 9, 2021

Uh oh!

Uh oh!

mary-poppins commented Nov 16, 2021

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Nov 16, 2021

Uh oh!

ngbot bot commented Nov 17, 2021

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Nov 17, 2021

Uh oh!

angular-automatic-lock-bot bot commented Dec 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AndrewKushnir commented Nov 5, 2021 •

edited

Loading