fix(getObject): null in return type for items#1183
Merged
Conversation
Haroenv
previously approved these changes
Aug 18, 2020
Contributor
|
seems like it's circle which is partially down, not the tests themselves per se. Can you do a force push? |
16efc5f to
b2cb768
Compare
b2cb768 to
52fab4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
getObjectsreturns an array of records but alsonullwhen the object id doesn't match any record. Updating the type to reflect that.See example of a response where the first object id matches a record and the second (object id "z") doesn't:
