feat(natural-languages): adds option#1147
Merged
nunomaduro merged 1 commit intomasterfrom Apr 23, 2020
Merged
Conversation
Haroenv
approved these changes
Apr 23, 2020
Contributor
Haroenv
left a comment
There was a problem hiding this comment.
good for now, in the previous version we maintained an actual list, but string is fine to prevent needless updates to the list
Author
|
@Haroenv Agree - putting that level of granularity is a pain to maintain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
naturalLanguagessearch options.Closes: #1107.