feat(types): introduce generic Hit type#1191
Merged
francoischalifour merged 4 commits intomasterfrom Sep 8, 2020
Merged
Conversation
Haroenv
reviewed
Sep 8, 2020
Haroenv
reviewed
Sep 8, 2020
Haroenv
reviewed
Sep 8, 2020
Contributor
Haroenv
left a comment
There was a problem hiding this comment.
looks good, but I think you used it in too many places, getObject(s) & browse don't have highlighting
Haroenv
reviewed
Sep 8, 2020
17bf1a0 to
82d6f8e
Compare
| * The list of results. | ||
| */ | ||
| results: Array<SearchResponse<TObject & ObjectWithObjectID>>; | ||
| results: Array<SearchResponse<TObject>>; |
Contributor
Author
There was a problem hiding this comment.
We used it pass ObjectWithObjectID here but it was already taken care of in SearchResponse, so we had it passed twice. This was not an issue since this type is just adding objectID another time.
Haroenv
approved these changes
Sep 8, 2020
Contributor
Haroenv
left a comment
There was a problem hiding this comment.
looks very good!
In the future I'd love to play with attributesToRetrieve & attributesToHighlight deciding which keys get responded, although I'm not sure if you can get all of that statically (since it could be a setting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new generic
Hittype that infers values for records' highlighting and snippeting results.