Merged
Conversation
- addMethods with `as` - updateApiKey with type guard - browseRules & browseSynonyms with `as any` (the key exists, but isn't supposed to be shown to the user, thus isn't in the type
for some reason if you do let x = something, you can't change the type anymore in a reassignment, except if you return directly, since that makes a new type
eunjae-lee
reviewed
Oct 9, 2020
| 'maxQueriesPerIPPerHour', | ||
| 'maxHitsPerQuery', | ||
| ]; | ||
| ] as const; |
Contributor
There was a problem hiding this comment.
just curiosity, there's no mutation on apiKeyFields below, and why as const?
Contributor
Author
There was a problem hiding this comment.
without as const, the type of updatedField lower is string, not the actual field values
Contributor
There was a problem hiding this comment.
Ah I didn't know. Thanks!
eunjae-lee
approved these changes
Oct 12, 2020
Contributor
eunjae-lee
left a comment
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asas any(the key exists, but isn't supposed to be shown to the user, thus isn't in the type