Skip to content

Fix 'Dictionary changed during iteration' exception raising#628

Merged
asvetlov merged 3 commits intomasterfrom
add_pypy_test
Sep 30, 2021
Merged

Fix 'Dictionary changed during iteration' exception raising#628
asvetlov merged 3 commits intomasterfrom
add_pypy_test

Conversation

@asvetlov
Copy link
Copy Markdown
Member

Don't raise 'Dictionary changed during iteration' when the error should not be thrown

Fix #620

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2021

Codecov Report

Merging #628 (e3b146f) into master (9dde0bd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.02%     
==========================================
  Files           5        5              
  Lines         499      498       -1     
==========================================
- Hits          468      467       -1     
  Misses         31       31              
Flag Coverage Δ
unit 93.77% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
multidict/_multidict_py.py 99.40% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dde0bd...e3b146f. Read the comment docs.

@asvetlov asvetlov merged commit 0cd7837 into master Sep 30, 2021
@asvetlov asvetlov deleted the add_pypy_test branch September 30, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

potential pypy mutability bug

3 participants