Skip to content

Switch to external frozenlist and aiosignal libraries#5293

Merged
asvetlov merged 6 commits intomasterfrom
drop-frozenlist-aiosignals
Nov 27, 2020
Merged

Switch to external frozenlist and aiosignal libraries#5293
asvetlov merged 6 commits intomasterfrom
drop-frozenlist-aiosignals

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Nov 26, 2020

Drop local copies

@asvetlov asvetlov requested a review from webknjaz as a code owner November 26, 2020 18:41
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 26, 2020
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Nov 26, 2020

This pull request fixes 1 alert when merging 14959e3 into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2020 •
edited
Loading

Codecov Report

Merging #5293 (278105a) into master (aa11d78) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5293      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files          43       41       -2     
  Lines        8803     8740      -63     
  Branches     1414     1406       -8     
==========================================
- Hits         8586     8524      -62     
  Misses        103      103              
+ Partials      114      113       -1
Flag Coverage Δ
unit 97.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/__init__.py 100.00% <ø> (ø)
aiohttp/test_utils.py 99.68% <100.00%> (ø)
aiohttp/tracing.py 100.00% <100.00%> (ø)
aiohttp/web_app.py 97.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa11d78...278105a. Read the comment docs.

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Nov 27, 2020

This pull request fixes 1 alert when merging 6377364 into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Nov 27, 2020

This pull request fixes 1 alert when merging 278105a into aa11d78 - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@asvetlov asvetlov merged commit 9f659ca into master Nov 27, 2020
@asvetlov asvetlov deleted the drop-frozenlist-aiosignals branch November 27, 2020 09:11
@aio-libs-github-bot
Copy link
Copy Markdown
Contributor

aio-libs-github-bot bot commented Nov 27, 2020

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Nov 27, 2020
@asvetlov
[3.8] Switch to external frozenlist and aiosignal libraries (#5293).
6530d39 
(cherry picked from commit 9f659ca)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Nov 27, 2020
@asvetlov
[3.8] Switch to external frozenlist and aiosignal libraries (#5293). (#…
135cb16 
…5294)

(cherry picked from commit 9f659ca)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@asvetlov @commonism
Switch to external frozenlist and aiosignal libraries (aio-libs#5293)
469b44a
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@asvetlov @commonism
Switch to external frozenlist and aiosignal libraries (aio-libs#5293)
9f28a35
@gilfree gilfree mentioned this pull request Nov 1, 2021
Closed
2 tasks
@TeoZosa TeoZosa mentioned this pull request Nov 11, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov